From e8e0518a08b8f6a12151beca6676d46adf106d20 Mon Sep 17 00:00:00 2001
From: Lucendio <dev@lucend.io>
Date: Sun, 11 Oct 2020 18:01:07 +0200
Subject: [PATCH] [client] remove glow & introduce a more flexible test
* glow is kinda distracting
* original test for title content prevents utilizing a change of
this characteristic form being used for demonstration purposed. The
additional test makes testing for the title more flexible and not
relying on its content
---
app/client/src/App.test.js | 8 +++++++-
app/client/src/components/Header/Header.css | 19 -------------------
app/client/src/components/Header/Header.js | 2 +-
3 files changed, 8 insertions(+), 21 deletions(-)
diff --git a/app/client/src/App.test.js b/app/client/src/App.test.js
index e48abed..45a71e3 100644
--- a/app/client/src/App.test.js
+++ b/app/client/src/App.test.js
@@ -2,8 +2,14 @@ import React from 'react';
import { render } from '@testing-library/react';
import App from './App';
-test('renders header title', () => {
+test.skip('renders header title "ToDo App"', () => {
const { getByText } = render(<App />);
const linkElement = getByText(/ToDo App/i);
expect(linkElement).toBeInTheDocument();
});
+
+test('renders a header title', () => {
+ const { container } = render(<App />);
+ const header = container.querySelector('.header-main')
+ expect(header).toHaveTextContent(/.+/);
+});
diff --git a/app/client/src/components/Header/Header.css b/app/client/src/components/Header/Header.css
index 3a82070..b63386e 100644
--- a/app/client/src/components/Header/Header.css
+++ b/app/client/src/components/Header/Header.css
@@ -10,22 +10,3 @@
font-size: 60px;
font-weight: 100;
}
-
-
-.glow {
- /* font-size: 80px; */
- color: #fff;
- text-align: center;
- -webkit-animation: glow 1s ease-in-out infinite alternate;
- -moz-animation: glow 1s ease-in-out infinite alternate;
- animation: glow 1s ease-in-out infinite alternate;
- }
-
- @keyframes glow {
- from {
- text-shadow: 0 0 10px #fff, 0 0 20px #fff, 0 0 30px white, 0 0 40px white, 0 0 50px white, 0 0 60px white, 0 0 70px white;
- }
- to {
- text-shadow: 0 0 20px #fff, 0 0 30px gray, 0 0 40px gray, 0 0 50px gray, 0 0 60px gray, 0 0 70px gray, 0 0 80px gray;
- }
- }
\ No newline at end of file
diff --git a/app/client/src/components/Header/Header.js b/app/client/src/components/Header/Header.js
index 5856e5e..ce81130 100644
--- a/app/client/src/components/Header/Header.js
+++ b/app/client/src/components/Header/Header.js
@@ -4,7 +4,7 @@ import './Header.css'
export default function Header() {
return (
- <MDBContainer className="header-main glow">
+ <MDBContainer className="header-main">
ToDo App
</MDBContainer>
)
--
GitLab