From ea913953ebe604bf2a870da445c565bc7256900c Mon Sep 17 00:00:00 2001
From: Lucendio <dev@lucend.io>
Date: Sun, 4 Oct 2020 19:51:42 +0200
Subject: [PATCH] Polish 'creating to' server test
* fix file name typo
* remove logs in test do reduce noise
* prevent 'connection established' log in test mode to reduce noise
* rename test to make it more obvious that it does not require (or create)
a user object
---
app/server/src/db/mongo.js | 2 +-
app/server/src/models/Todos.test.js | 18 +++++++-----------
.../src/models/{Uers.test.js => Users.test.js} | 0
3 files changed, 8 insertions(+), 12 deletions(-)
rename app/server/src/models/{Uers.test.js => Users.test.js} (100%)
diff --git a/app/server/src/db/mongo.js b/app/server/src/db/mongo.js
index 365992b..fbfa200 100644
--- a/app/server/src/db/mongo.js
+++ b/app/server/src/db/mongo.js
@@ -32,7 +32,7 @@ const mongooseInstance_ = mongoose.connect(
mongooseInstance_
.then(()=>{
- console.log( `Connect established to database: ${ process.env.MONGODB_URL }` );
+ process.env.NODE_ENV !== 'test' && console.log( `Connect established to database: ${ process.env.MONGODB_URL }` );
})
.catch(( err )=>{
console.error( `Cannot connect to database: ${ process.env.MONGODB_URL }` );
diff --git a/app/server/src/models/Todos.test.js b/app/server/src/models/Todos.test.js
index f354aa6..21cfd36 100644
--- a/app/server/src/models/Todos.test.js
+++ b/app/server/src/models/Todos.test.js
@@ -1,23 +1,21 @@
+const mongoose = require( 'mongoose' );
const dbClientInstance_ = require( '../db/mongo.js' );
+
const { model: Todos } = require( './Todos.js' );
-const mongoose = require('mongoose');
-describe( 'Todos: Todos', ()=>{
+describe( 'Model: Todos', ()=>{
beforeAll( async ()=>{
try{
await dbClientInstance_;
}catch( err ){
- console.warn("Error")
console.error( new Error( `Cannot connect to database: ${ process.env.MONGODB_URL }` ) );
process.exit( 1 );
}
});
- test( 'creating a todo', async ()=>{
-
- console.debug("Creating Todo")
+ test( 'creating a todo for a non-existing user', async ()=>{
const todoData = {
title: 'Homework',
@@ -25,12 +23,11 @@ describe( 'Todos: Todos', ()=>{
user: mongoose.Types.ObjectId()
};
- console.warn("Done")
const todoDoc = await Todos( todoData );
await todoDoc.save();
- console.warn("todo Record")
+
const todoRecord = await Todos.findOne({ user: todoData.user });
- console.warn("PW")
+
const { description, ...todoInfo } = todoData;
expect( todoRecord ).toEqual( expect.objectContaining( todoInfo ) );
@@ -38,10 +35,9 @@ describe( 'Todos: Todos', ()=>{
afterAll( async ()=>{
- console.warn("PW2")
const dbClient = await dbClientInstance_;
const { connection } = dbClient;
await connection.dropDatabase();
await dbClient.disconnect();
});
-});
\ No newline at end of file
+});
diff --git a/app/server/src/models/Uers.test.js b/app/server/src/models/Users.test.js
similarity index 100%
rename from app/server/src/models/Uers.test.js
rename to app/server/src/models/Users.test.js
--
GitLab