From 5a6c108efbb0df1f32258e97981957bbaccae29c Mon Sep 17 00:00:00 2001
From: Joe Freeman <joe+github@freemansoft.com>
Date: Wed, 30 Sep 2015 21:20:34 -0400
Subject: [PATCH] Added comments when CallMonitoringAspect called
CallMonitoringAspect is not invoked when spring-data-jpa is used. Spent
4 hours trying to understand why jmx bean wasn't showing message counts.
Use JPA or JDBC if you want call counts exposed via JMX / AOP
---
pom.xml | 4 ----
.../samples/petclinic/util/CallMonitoringAspect.java | 2 ++
src/main/webapp/WEB-INF/web.xml | 2 ++
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/pom.xml b/pom.xml
index 989ba3c..3f2e357 100644
--- a/pom.xml
+++ b/pom.xml
@@ -88,10 +88,6 @@
<artifactId>taglibs-standard-jstlel</artifactId>
</dependency>
<!-- JSon -->
- <dependency>
- <groupId>com.googlecode.json-simple</groupId>
- <artifactId>json-simple</artifactId>
- </dependency>
<dependency>
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path</artifactId>
diff --git a/src/main/java/org/springframework/samples/petclinic/util/CallMonitoringAspect.java b/src/main/java/org/springframework/samples/petclinic/util/CallMonitoringAspect.java
index 3c69984..494d650 100644
--- a/src/main/java/org/springframework/samples/petclinic/util/CallMonitoringAspect.java
+++ b/src/main/java/org/springframework/samples/petclinic/util/CallMonitoringAspect.java
@@ -26,6 +26,8 @@ import org.springframework.util.StopWatch;
/**
* Simple aspect that monitors call count and call invocation time. It uses JMX annotations and therefore can be
* monitored using any JMX console such as the jConsole
+ *
+ * This is only useful if you use JPA or JDBC. Spring-data-jpa doesn't have any correctly annotated classes to join on
*
* @author Rob Harrop
* @author Juergen Hoeller
diff --git a/src/main/webapp/WEB-INF/web.xml b/src/main/webapp/WEB-INF/web.xml
index bd3ea6d..e0c93f4 100644
--- a/src/main/webapp/WEB-INF/web.xml
+++ b/src/main/webapp/WEB-INF/web.xml
@@ -8,6 +8,7 @@
<display-name>Spring PetClinic</display-name>
<description>Spring PetClinic sample application</description>
+ <!-- When using Spring jpa, use the following: -->
<context-param>
<param-name>spring.profiles.active</param-name>
<param-value>jpa</param-value>
@@ -19,6 +20,7 @@
<param-value>jdbc</param-value>
</context-param> -->
+ <!-- the CallMonitoringAspect counts invocations on classes with @Repository on them. Classes in spring-data-jpa don't have that annotation -->
<!-- When using Spring Data JPA, uncomment the following: -->
<!--
<context-param>
--
GitLab