diff --git a/pom.xml b/pom.xml index 59fdd762965fead00fa5ee96e113bfeba85d1263..ffdbf51aa95d5dd5e4d52d97831e14e777bf88a8 100644 --- a/pom.xml +++ b/pom.xml @@ -66,6 +66,8 @@ <mysql.version>5.1.22</mysql.version> + <cobertura.version>2.7</cobertura.version> + </properties> <dependencies> @@ -442,8 +444,39 @@ <path>/petclinic</path> </configuration> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>cobertura-maven-plugin</artifactId> + <version>${cobertura.version}</version> + <configuration> + </configuration> + <executions> + <execution> + <goals> + <goal>clean</goal> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> </plugins> </build> + <reporting> + <plugins> + + <!-- integrate maven-cobertura-plugin to project site --> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>cobertura-maven-plugin</artifactId> + <version>${cobertura.version}</version> + <configuration> + <formats> + <format>html</format> + </formats> + </configuration> + </plugin> + </plugins> + </reporting> <url>demopetclinic</url> </project> diff --git a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java index 4ae19653a4c87970d625390e71e3a8327cadcba2..579de528460397b023f71b659d22f5b492a16a76 100644 --- a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java +++ b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java @@ -122,6 +122,7 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository { ); for (JdbcPet pet : pets) { owner.addPet(pet); + // Pet types have not been loaded at this stage. They are loaded separately pet.setType(EntityUtils.getById(getPetTypes(), PetType.class, pet.getTypeId())); List<Visit> visits = this.visitRepository.findByPetId(pet.getId()); for (Visit visit : visits) { diff --git a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java index f2ed258238b06c7fb07e20799499514567065a93..39ba53b83a84dce998aea18000f73c03456e6620 100644 --- a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java +++ b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java @@ -19,7 +19,7 @@ import org.springframework.samples.petclinic.model.Pet; /** * Subclass of Pet that carries temporary id properties which are only relevant for a JDBC implementation of the - * ClinicService. + * PetRepository. * * @author Juergen Hoeller */ diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java index 0c80d06fbd3bc19fdbde4f7cba8926a79879b6cf..f8582b5d9fbaea898bcc3a831ba441d3a835a944 100644 --- a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java +++ b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java @@ -8,8 +8,6 @@ import java.util.Set; import javax.validation.ConstraintViolation; import javax.validation.Validator; -import org.assertj.core.api.Assertions; -import org.junit.Assert; import org.junit.Test; import org.springframework.context.i18n.LocaleContextHolder; import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean; @@ -40,7 +38,7 @@ public class ValidatorTests { Validator validator = createValidator(); Set<ConstraintViolation<Person>> constraintViolations = validator.validate(person); - Assert.assertEquals(1, constraintViolations.size()); + assertThat(constraintViolations.size()).isEqualTo(1); ConstraintViolation<Person> violation = constraintViolations.iterator().next(); assertThat(violation.getPropertyPath().toString()).isEqualTo("firstName"); assertThat(violation.getMessage()).isEqualTo("may not be empty");