From c0aefa7ed8d28e3e179b768c249837c9d0d1271a Mon Sep 17 00:00:00 2001
From: Yoel <s73017@beuth-hochschule.de>
Date: Fri, 11 Sep 2020 19:38:51 +0200
Subject: [PATCH] Changed some parameters to const-refs
---
RayTracer/tools/Threadpool.cpp | 4 ++--
RayTracer/tools/Threadpool.h | 2 +-
RayTracer/tools/Transformation.cpp | 2 +-
RayTracer/tools/Transformation.h | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/RayTracer/tools/Threadpool.cpp b/RayTracer/tools/Threadpool.cpp
index 1f017e1..2336571 100644
--- a/RayTracer/tools/Threadpool.cpp
+++ b/RayTracer/tools/Threadpool.cpp
@@ -18,10 +18,10 @@ Threadpool::~Threadpool() {
alive = false;
cv.notify_all();
- for (auto &thread : threads) thread.join();
+ for (auto& thread : threads) thread.join();
}
-void Threadpool::queueTask(std::function<void(void)> task) {
+void Threadpool::queueTask(const std::function<void(void)>& task) {
std::unique_lock<std::mutex> lock(m);
q.emplace(task);
lock.unlock();
diff --git a/RayTracer/tools/Threadpool.h b/RayTracer/tools/Threadpool.h
index bc003e0..55a97dc 100644
--- a/RayTracer/tools/Threadpool.h
+++ b/RayTracer/tools/Threadpool.h
@@ -13,7 +13,7 @@ class Threadpool {
Threadpool(size_t n);
~Threadpool();
// Add a task to the queue
- void queueTask(std::function<void(void)> task);
+ void queueTask(const std::function<void(void)>& task);
private:
void threading();
diff --git a/RayTracer/tools/Transformation.cpp b/RayTracer/tools/Transformation.cpp
index 86eed88..d5149d8 100644
--- a/RayTracer/tools/Transformation.cpp
+++ b/RayTracer/tools/Transformation.cpp
@@ -1,7 +1,7 @@
#include "Transformation.h"
namespace util {
-util::Transformation::Transformation(Mat4 matrix)
+util::Transformation::Transformation(const Mat4& matrix)
: toWorld(matrix),
fromWorld(matrix.invertFull()),
toWorldN(matrix.invertFull().transpose()) {
diff --git a/RayTracer/tools/Transformation.h b/RayTracer/tools/Transformation.h
index 43d05b9..f5e09a5 100644
--- a/RayTracer/tools/Transformation.h
+++ b/RayTracer/tools/Transformation.h
@@ -4,7 +4,7 @@
namespace util {
class Transformation {
public:
- Transformation(Mat4 matrix);
+ Transformation(const Mat4& matrix);
const Mat4 toWorld, fromWorld, toWorldN;
};
} // namespace util
\ No newline at end of file
--
GitLab