Store actual items in ephemeral storage instead of pointers

The location where the actual items should reside is in the store, while
only references are being returned when attempting to access an item.

state/ephemeral.go

@@ -20,7 +20,7 @@ func NewEphemeralStore() *Ephemeral {
 }
 
 
-func ( e *Ephemeral ) Add( i *Item ) error {
+func ( e *Ephemeral ) Add( i Item ) error {
     if e.store == nil {
         return errors.New( "ephemeral storage not available" )
     }
@@ -60,7 +60,7 @@ func ( e *Ephemeral ) Fetch( name string ) ( *Item, error ) {
     if !found {
         return nil, nil
     }
-    return item, nil
+    return &item, nil
 }
 
 

state/item.go

@@ -8,8 +8,8 @@ type Item struct {
 }
 
 
-func NewItem( name string, mimeType string, data []byte ) *Item {
-    return &Item{
+func NewItem( name string, mimeType string, data []byte ) Item {
+    return Item{
         name: name,
         mimeType: mimeType,
         data: data,

state/persistent.go

@@ -44,7 +44,7 @@ func NewPersistentStore( c *configuration.Config ) *Persistent {
 }
 
 
-func ( e *Persistent ) Add( i *Item ) error {
+func ( e *Persistent ) Add( i Item ) error {
     ctx, cancel := context.WithTimeout( context.TODO(), e.timeout )
     defer cancel()
 
@@ -82,7 +82,8 @@ func ( e *Persistent ) Fetch( name string ) ( *Item, error ) {
 
     var item *Item = nil
     if len( value ) >= 1 {
-        item = NewItem( name, value[ "mime" ], []byte( value[ "data" ] ) )
+        i := NewItem( name, value[ "mime" ], []byte( value[ "data" ] ) )
+        item = &i
     }
     return item, nil
 }

state/store.go

@@ -3,7 +3,7 @@ package state
 
 
 type Store interface {
-    Add( i *Item ) error
+    Add( i Item ) error
     Remove( name string ) error
     Fetch( name string ) ( *Item, error )
     Show() ( []string, error )