BackgroundMaterial, comments and refactor

RayTracer/material/BackgroundMaterial.cpp

@@ -17,6 +17,7 @@ BackgroundMaterial::BackgroundMaterial(
 BackgroundMaterial::BackgroundMaterial(const util::Vec3& albedo)
     : emission_profile({std::make_shared<Constant>(albedo)}) {
 }
+// Everything in the background material is derived from its emission profile
 util::Vec3 BackgroundMaterial::albedo(const std::pair<float, float>& uv) const {
 	return util::Vec3(1, 1, 1);
 }
@@ -24,6 +25,8 @@ util::Vec3 BackgroundMaterial::emission(
     const std::pair<float, float>& uv) const {
 	return emission_profile.color(uv.first, uv.second);
 }
+// This gives us the sampled points uv, which is than used to get the value of
+// the pdf and the emission value of the texture
 std::pair<float, float> BackgroundMaterial::sampleEmissionProfile() const {
 	return emission_profile.sample();
 }
@@ -31,14 +34,17 @@ std::pair<float, float> BackgroundMaterial::sampleEmissionProfile() const {
 std::optional<float> BackgroundMaterial::emission_pdf(float u, float v) const {
 	return emission_profile.pdf(u, v);
 }
-util::Vec3 BackgroundMaterial::scattered_d(const util::Vec3& d,
-                                           const util::Vec3& n) const {
-	return util::Vec3(0, 0, 0);
+// Gets called because scatter checks for the outgoing vector.
+// Only really used for reflective material
+std::optional<util::Vec3> BackgroundMaterial::scattered_d(
+    const util::Vec3& d, const util::Vec3& n) const {
+	return std::nullopt;
 }
+/*
 bool BackgroundMaterial::scatter(const util::Vec3& d,
                                  const util::Vec3& n) const {
-	return false;
-}
+    return false;
+}*/
 
 float BackgroundMaterial::calculateLightMultiplier(const util::Vec3& d_in,
                                                    const util::Vec3& d_out,
@@ -46,6 +52,7 @@ float BackgroundMaterial::calculateLightMultiplier(const util::Vec3& d_in,
 	// Background should not be able to receive any light
 	return 0;
 }
+// Should never get called
 float BackgroundMaterial::brdf_pdf(const util::Vec3& d_out,
                                    const util::Vec3& n) const {
 	// Background can not scatter so this is fine and will never be used

RayTracer/material/BackgroundMaterial.h

@@ -14,14 +14,12 @@ class BackgroundMaterial : public Material {
 	util::Vec3 albedo(const std::pair<float, float>& uv) const override;
 	util::Vec3 emission(const std::pair<float, float>& uv) const override;
 	std::pair<float, float> sampleEmissionProfile() const override;
-	util::Vec3 scattered_d(const util::Vec3& d,
-	                       const util::Vec3& n) const override;
-	bool scatter(const util::Vec3& d, const util::Vec3& n) const override;
-
+	std::optional<util::Vec3> scattered_d(const util::Vec3& d,
+	                                      const util::Vec3& n) const override;
+	// bool scatter(const util::Vec3& d, const util::Vec3& n) const override;
 	float calculateLightMultiplier(const util::Vec3& d_in,
 	                               const util::Vec3& d_out,
 	                               const util::Vec3& n) const override;
-
 	float brdf_pdf(const util::Vec3& d_out, const util::Vec3& n) const override;
 	std::optional<float> emission_pdf(float u, float v) const override;